Fix same-window folder drop guard

This commit is contained in:
Mikei386
2026-06-23 12:05:14 +02:00
parent 25fa0ce644
commit 50c685ee80
7 changed files with 34 additions and 8 deletions
+1 -1
View File
@@ -2,7 +2,7 @@
set -eu set -eu
PLUGIN="u-navigator" PLUGIN="u-navigator"
VERSION="2026.06.23.r023" VERSION="2026.06.23.r024"
PKG_DIR="packages" PKG_DIR="packages"
WORK_DIR=".plugin-build" WORK_DIR=".plugin-build"
PKG_NAME="${PLUGIN}-${VERSION}.tgz" PKG_NAME="${PLUGIN}-${VERSION}.tgz"
Binary file not shown.
Binary file not shown.
@@ -164,7 +164,9 @@ function unav_guard_destination(string $source, string $destination): void {
if (file_exists($destination)) { if (file_exists($destination)) {
unav_error(409, 'Destination already exists'); unav_error(409, 'Destination already exists');
} }
if ($source === $destination || str_starts_with($destination, rtrim($source, '/') . '/')) { $normalizedSource = rtrim($source, '/');
$normalizedDestination = rtrim($destination, '/');
if ($normalizedSource === $normalizedDestination || (is_dir($source) && str_starts_with($normalizedDestination, $normalizedSource . '/'))) {
unav_error(400, 'Destination cannot be inside source'); unav_error(400, 'Destination cannot be inside source');
} }
} }
@@ -54,7 +54,9 @@ function unav_worker_guard(string $source, string $destination): void {
if (file_exists($destinationPath)) { if (file_exists($destinationPath)) {
throw new RuntimeException('Destination already exists'); throw new RuntimeException('Destination already exists');
} }
if ($sourceReal === $destinationPath || str_starts_with($destinationPath, rtrim($sourceReal, '/') . '/')) { $normalizedSource = rtrim($sourceReal, '/');
$normalizedDestination = rtrim($destinationPath, '/');
if ($normalizedSource === $normalizedDestination || (is_dir($sourceReal) && str_starts_with($normalizedDestination, $normalizedSource . '/'))) {
throw new RuntimeException('Destination cannot be inside source'); throw new RuntimeException('Destination cannot be inside source');
} }
} }
+25 -3
View File
@@ -892,11 +892,18 @@ async function finishItemPointerDrag(event, move, up) {
} }
try { try {
const destination = `${target.path.replace(/\/$/, '')}/${drag.name}`; const destination = joinPath(target.path, drag.name);
if (destination === drag.path) { recordDebug('pointer.destination', {
source: drag.path,
targetPath: target.path,
destination,
targetIsRow: Boolean(target.row),
copy: event.altKey
});
if (destination === drag.path || target.path === drag.path) {
throw new Error('Quelle und Ziel sind identisch.'); throw new Error('Quelle und Ziel sind identisch.');
} }
if (drag.type === 'directory' && target.path.startsWith(`${drag.path.replace(/\/$/, '')}/`)) { if (drag.type === 'directory' && isPathInside(target.path, drag.path)) {
throw new Error('Ein Ordner kann nicht in sich selbst verschoben werden.'); throw new Error('Ein Ordner kann nicht in sich selbst verschoben werden.');
} }
await createJob(event.altKey ? 'copy' : 'move', drag.path, destination, [drag.sourceWindowId, target.windowId]); await createJob(event.altKey ? 'copy' : 'move', drag.path, destination, [drag.sourceWindowId, target.windowId]);
@@ -1132,6 +1139,21 @@ function dirname(value) {
return `/${parts.slice(0, -1).join('/')}`; return `/${parts.slice(0, -1).join('/')}`;
} }
function joinPath(parent, name) {
return `${String(parent || '').replace(/\/+$/, '')}/${String(name || '').replace(/^\/+/, '')}`;
}
function normalizePath(value) {
const parts = String(value || '').split('/').filter(Boolean);
return `/${parts.join('/')}`;
}
function isPathInside(path, parent) {
const normalizedPath = normalizePath(path);
const normalizedParent = normalizePath(parent);
return normalizedPath.startsWith(`${normalizedParent.replace(/\/$/, '')}/`);
}
function formatBytes(bytes) { function formatBytes(bytes) {
const value = Number(bytes || 0); const value = Number(bytes || 0);
if (value < 1024) return `${value} B`; if (value < 1024) return `${value} B`;
+2 -2
View File
@@ -1,7 +1,7 @@
<!DOCTYPE PLUGIN [ <!DOCTYPE PLUGIN [
<!ENTITY name "u-navigator"> <!ENTITY name "u-navigator">
<!ENTITY author "Michael Roll"> <!ENTITY author "Michael Roll">
<!ENTITY version "2026.06.23.r023"> <!ENTITY version "2026.06.23.r024">
<!ENTITY package "&name;-&version;.tgz"> <!ENTITY package "&name;-&version;.tgz">
<!ENTITY pluginURL "https://git.casaderoll.de/michael/Unraid-Navigator/raw/branch/main/u-navigator.plg"> <!ENTITY pluginURL "https://git.casaderoll.de/michael/Unraid-Navigator/raw/branch/main/u-navigator.plg">
<!ENTITY support "https://git.casaderoll.de/michael/Unraid-Navigator"> <!ENTITY support "https://git.casaderoll.de/michael/Unraid-Navigator">
@@ -24,7 +24,7 @@
<FILE Name="/boot/config/plugins/&name;/&package;"> <FILE Name="/boot/config/plugins/&name;/&package;">
<URL>https://git.casaderoll.de/michael/Unraid-Navigator/raw/branch/main/packages/&package;</URL> <URL>https://git.casaderoll.de/michael/Unraid-Navigator/raw/branch/main/packages/&package;</URL>
<MD5>c57cb70f4d040d65869b6ffde469b18a</MD5> <MD5>460c859d05c48638ba4c30e51e040b65</MD5>
</FILE> </FILE>
<FILE Run="/bin/bash"> <FILE Run="/bin/bash">