Harden backup and restore operations

internal/service/safety_test.go

@@ -0,0 +1,67 @@
+package service
+
+import (
+	"context"
+	"os"
+	"path/filepath"
+	"testing"
+	"time"
+
+	"git.casaderoll.de/michael/urbm/internal/model"
+)
+
+func TestRepositoryLockHonorsContextCancellation(t *testing.T) {
+	s := &Service{repositoryLocks: map[string]chan struct{}{}}
+	repo := model.Repository{Type: model.RepositoryLocal, Location: "/repo"}
+	unlock, err := s.lockRepository(context.Background(), repo)
+	if err != nil {
+		t.Fatal(err)
+	}
+	ctx, cancel := context.WithTimeout(context.Background(), 20*time.Millisecond)
+	defer cancel()
+	if _, err := s.lockRepository(ctx, repo); err == nil {
+		t.Fatal("concurrent repository access ignored the request deadline")
+	}
+	unlock()
+}
+
+func TestPersistentRunLogsAreWrittenAndPruned(t *testing.T) {
+	dir := t.TempDir()
+	config := model.DefaultConfig()
+	config.Settings.PersistentLogDir = dir
+	s := &Service{config: config}
+	finished := time.Now()
+	run := model.Run{ID: "run-1", FinishedAt: &finished, LiveLog: []string{"first", "second"}}
+	if err := s.persistRunLogs([]model.Run{run}); err != nil {
+		t.Fatal(err)
+	}
+	path := filepath.Join(dir, "urbm-run-1.log")
+	if contents, err := os.ReadFile(path); err != nil || string(contents) != "first\nsecond\n" {
+		t.Fatalf("persistent log = %q, %v", contents, err)
+	}
+	if err := s.persistRunLogs(nil); err != nil {
+		t.Fatal(err)
+	}
+	if _, err := os.Stat(path); !os.IsNotExist(err) {
+		t.Fatalf("cleared run log still exists: %v", err)
+	}
+}
+
+func TestQueuePersistenceDoesNotBlockWhenWriterIsBusy(t *testing.T) {
+	s := &Service{persistRuns: make(chan []model.Run, 1)}
+	s.persistRuns <- []model.Run{{ID: "old"}}
+	done := make(chan struct{})
+	go func() {
+		s.queuePersistence([]model.Run{{ID: "latest"}})
+		close(done)
+	}()
+	select {
+	case <-done:
+	case <-time.After(100 * time.Millisecond):
+		t.Fatal("queue persistence blocked the queue callback")
+	}
+	runs := <-s.persistRuns
+	if len(runs) != 1 || runs[0].ID != "latest" {
+		t.Fatalf("queued persistence state = %#v", runs)
+	}
+}